fix: handle differing indent levels for jobTemplate vs template#135
Open
etrikp wants to merge 5 commits intoarttor:mainfrom
Open
fix: handle differing indent levels for jobTemplate vs template#135etrikp wants to merge 5 commits intoarttor:mainfrom
etrikp wants to merge 5 commits intoarttor:mainfrom
Conversation
etrikp
changed the title
arttor
requested changes
Feb 20, 2024
arttor
requested changes
Mar 8, 2024
| spec: | ||
| containers: | ||
| - command: | ||
| - args: {{- toYaml .Values.batchJob.pi.args | nindent 12 }} |
Owner
There was a problem hiding this comment.
for CronJob nindent 12 is correct, but for Job it should be less because it does not have jobTemplate, right?
Comment on lines
+24
to
+25
| resources: {{- toYaml .Values.batchJob.pi.resources | nindent 14 }} | ||
| nodeSelector: {{- toYaml .Values.batchJob.nodeSelector | nindent 12 }} |
Owner
There was a problem hiding this comment.
same applies here: nindent should be less than for CronJob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional test data, test suite passes.